Use GitHub Actions for linting and testing as well as update gemspec #71
Conversation
erickguan
force-pushed
the
pipeline
branch
13 times, most recently
from
a438249
to
cfaae6f
Compare
erickguan
changed the title
| merge: | ||
| - Exclude | ||
|
|
||
| require: |
There was a problem hiding this comment.
Maybe later we can add rubocop-performance
| Style/StringLiterals: | ||
| Enabled: true | ||
| EnforcedStyle: single_quotes |
There was a problem hiding this comment.
This is the default, is your intention here to be explicit on these style decisions?
There was a problem hiding this comment.
Yes. I agree that we should use as many defaults as possible. For some rules that have a large "surface", I would mark them explicitly.
.rubocop.yml
Outdated
| # Enforce comma after the last item of a multiline array or hash | ||
| Style/TrailingCommaInArrayLiteral: | ||
| Enabled: true | ||
| EnforcedStyleForMultiline: comma |
There was a problem hiding this comment.
This pattern doesn't follow the recommended Ruby Programming Style. I would recommend following up to use default styling for this, Style/TrailingCommaInHashLiteral, and Style/TrailingCommaInArguments.
| EnforcedStyle: trailing | ||
|
|
||
| Layout/LineLength: | ||
| Max: 120 |
There was a problem hiding this comment.
This is the default value. Recommend removing things that are default to reduce config size.
.rubocop.yml
Outdated
|
|
||
| # Allow guard clauses | ||
| Style/GuardClause: | ||
| Enabled: true |
.rubocop.yml
Outdated
|
|
||
| # Naming conventions | ||
| Naming/PredicateName: | ||
| Enabled: true |
.rubocop.yml
Outdated
|
|
||
| Metrics/BlockLength: | ||
| Max: 50 | ||
|
|
|
|
||
| Example: | ||
|
|
||
| ```ruby | ||
| ICU::Transliteration.transliterate('Traditional-Simplified', '沈從文') # => "沈从文" | ||
| ``` | ||
|
|
||
| Locale |
There was a problem hiding this comment.
Good catch. I made a mistake.
lib/ffi-icu/locale.rb
Outdated
| # rubocop:disable Style/OptionalBooleanParameter | ||
| def to_language_tag(strict = false) | ||
| Lib::Util.read_string_buffer(64) do |buffer, status| | ||
| Lib.uloc_toLanguageTag(@id, buffer, buffer.size, strict ? 1 : 0, status) | ||
| end | ||
| end | ||
| # rubocop:enable Style/OptionalBooleanParameter |
There was a problem hiding this comment.
These enable/disable cop comments it can also be done on one line.
| # rubocop:disable Style/OptionalBooleanParameter | |
| def to_language_tag(strict = false) | |
| Lib::Util.read_string_buffer(64) do |buffer, status| | |
| Lib.uloc_toLanguageTag(@id, buffer, buffer.size, strict ? 1 : 0, status) | |
| end | |
| end | |
| # rubocop:enable Style/OptionalBooleanParameter | |
| def to_language_tag(strict = false) # rubocop:disable Style/OptionalBooleanParameter | |
| Lib::Util.read_string_buffer(64) do |buffer, status| | |
| Lib.uloc_toLanguageTag(@id, buffer, buffer.size, strict ? 1 : 0, status) | |
| end | |
| end |
There was a problem hiding this comment.
Same with some other files.
lib/ffi-icu/version.rb
Outdated
| @@ -1,3 +1,3 @@ | |||
| module ICU | |||
| VERSION = "0.5.3" | |||
| VERSION = '0.5.3'.freeze | |||
There was a problem hiding this comment.
Adding the # frozen_string_literal: true comment could help. Related cop.
.rubocop.yml
Outdated
| Include: | ||
| - '*.gemspec' | ||
|
|
||
| # ALlow no documentation. |
There was a problem hiding this comment.
| # ALlow no documentation. | |
| # Allow no documentation. |
- Use simpler syntax for README - Update LICENSE date - Set up changelog
erickguan
force-pushed
the
pipeline
branch
2 times, most recently
from
21be71e
to
e72e108
Compare
erickguan
force-pushed
the
pipeline
branch
3 times, most recently
from
0d0c513
to
7b0452a
Compare
Add GitHub workflows for linting and testing.
This PR also uses rubocop and update a few gemspec defintions.
It would be nice to move to minitest.